Fix flaky subscription test #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* a 1ms sleep between setup and the start of publishing; and * a maximum-2s loop of 10ms sleeps to wait for message delivery. Both features appear to be required to ensure reliable test results when the system is under load (e.g., `stress -c 8` on an 8-core machine).
|
FYI, the sleep-loop structure is the same as was used in #94. |
gerkey
added
in review
|
The changes look good, here is an OS X job with just Connext enabled (mostly to ensure that this didn't break the test, not to check that the flakiness is gone): http://ci.ros2.org/job/ci_osx/685/ In parallel I'll test it locally. |
|
Sneak peak from that CI job: |
|
It's green. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky subscription test by adding:
Both features appear to be required to ensure reliable test results with Connext when the system is under load.
These tests fail under CI most often with Connext on OSX (e.g., http://ci.ros2.org/job/ci_osx/679/testReport/%28root%29/projectroot/gtest_subscription__rmw_connext_cpp/). To reproduce locally, I load my 8-core Linux machine with
stress -c 8. I consider the problem "fixed" when the test passes under those conditions.