Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humble migration missing a mention of addtion of header file directory layer? #3702

Closed
130s opened this issue Jun 4, 2023 · 1 comment · Fixed by #3703
Closed

Humble migration missing a mention of addtion of header file directory layer? #3702

130s opened this issue Jun 4, 2023 · 1 comment · Fixed by #3703

Comments

@130s
Copy link
Contributor

130s commented Jun 4, 2023

As asked in answers.ros.org#405158, project/package directories under include are multi-layered since Humble.

IMO this broke some dev environment (e.g. IDE setting (VS Code unable to reference headers robotics.stackexchange.com#24211 so is Eclipse)) IINM, and yet I do not see the change mentioned in the migration note (closest might be ament-cmake-gen-version-h in Humble migration note (docs.ros.org), which looks like a part of ros2/ros2#1150 Tully mentions).

Am I wrong?

@clalancette
Copy link
Contributor

(closest might be ament-cmake-gen-version-h in Humble migration note (docs.ros.org), which looks like a part of ros2/ros2#1150 Tully mentions).

No, that's a different thing. The most important post in that issue is ros2/ros2#1150 (comment) , where Shane lays out the various options. We ended up implementing Option 2 (and partially Option 4).

IMO this broke some dev environment (e.g. IDE setting (VS Code unable to reference headers robotics.stackexchange.com#24211 so is Eclipse)) IINM, and yet I do not see the change mentioned in the migration note

You are correct, there is no mention of this in the release notes. I'll go ahead and add one. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants