Fix warnings when using mypy 1.8.0. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons I admit I don't understand, when using mypy 1.8.0 with this code it fails to determine that it can import submodules from launch properly. Since we can easily workaround this by just doing 'import launch', do that here. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
christophebedard
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
I think I've come across these errors (or similar ones) before in #27. It might be due to the [no-]implicit-reexport flag: https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport. So it might not like imports of an implicitly-reexported value even though it works in practice.
Nevertheless, this is fine.
|
CI:
|
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I admit I don't understand, when using mypy 1.8.0 with this code it fails to determine that it can import submodules from launch properly. Since we can easily workaround this by just doing 'import launch', do that here.