remove apparently unused yaml dependency #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
added
in progress
dirk-thomas
approved these changes
Aug 7, 2018
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* move launch_testing module into legacy namespace * add legacy imports to maintain backward compatibility
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
Signed-off-by: Miaofei <miaofei@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this when reviewing another PR.
I think this was a copy-paste from other packages actually using yaml.
Requesting review from @dirk-thomas that implemented these 2 verbs