Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make listing hidden services symmetric with topics #162

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Dec 3, 2018

The ros2 service command and ros2 service list command both had --include-hidden-services arguments. Because of the latter the first argument did nothing. This makes listing hidden services the same as listing hidden topics

Before

# this would show no error, and not show hidden services
ros2 service --include-hidden-services list
# this would show hidden services
ros2 service list --include-hidden-services

With this PR

# this shows hidden services.
ros2 service --include-hidden-services list
# this shows hidden topics
ros2 topic --include-hidden-topics list

@sloretz sloretz added the in review Waiting for review (Kanban column) label Dec 3, 2018
@sloretz sloretz self-assigned this Dec 3, 2018
@sloretz
Copy link
Contributor Author

sloretz commented Dec 3, 2018

CI only linux for linters Build Status

@sloretz sloretz merged commit 813eefa into master Dec 3, 2018
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Dec 3, 2018
@sloretz sloretz deleted the list_hidden_services branch December 3, 2018 22:08
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants