Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for service type name without 'srv' namespace part #247

Merged
merged 1 commit into from
May 22, 2019
Merged

add support for service type name without 'srv' namespace part #247

merged 1 commit into from
May 22, 2019

Conversation

dirk-thomas
Copy link
Member

Keeps legacy support to improve behavior reported in ros2/demos#344.

@dirk-thomas
add support for service type name without 'srv' namespace part
437c7e6 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added enhancement New feature or request in review Waiting for review (Kanban column) labels May 22, 2019
@dirk-thomas dirk-thomas self-assigned this May 22, 2019
@dirk-thomas dirk-thomas mentioned this pull request May 22, 2019
Closed
@dirk-thomas dirk-thomas merged commit ce0ff93 into master May 22, 2019
@dirk-thomas dirk-thomas deleted the support_old_service_type_name branch May 22, 2019 17:51
jacobperron added a commit that referenced this pull request May 29, 2019
@jacobperron
[ros2action] Support multiple part action type names for 'send_goal' …
fd7e3ec 
…verb

Similar to the changes made in #247 and #259.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request May 29, 2019
Merged
jacobperron added a commit that referenced this pull request May 29, 2019
@jacobperron
[ros2action] Support multiple part action type names for 'send_goal' …
2de6f09 
…verb (#261)

Similar to the changes made in #247 and #259.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skucheria skucheria skucheria approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
enhancement New feature or request in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirk-thomas @skucheria