Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset goal_handle to avoid attempt to cancel #254

Merged
merged 2 commits into from
May 23, 2019
Merged

Conversation

dirk-thomas
Copy link
Member

Fixes #219.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels May 23, 2019
@dirk-thomas dirk-thomas self-assigned this May 23, 2019
@dirk-thomas dirk-thomas merged commit eb5d2b7 into master May 23, 2019
@dirk-thomas dirk-thomas deleted the dirk-thomas/fix219 branch May 23, 2019 18:06
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
…ommand (ros2#254)

* Added launch-prefix argument for 'ros2 launch' command

Signed-off-by: Cameron Miller <cammlle@amazon.com>

* Pass launch-prefix to LaunchService

Signed-off-by: Cameron Miller <cammlle@amazon.com>

* Revert to commit: fca036eb0

Signed-off-by: Cameron Miller <cammlle@amazon.com>

Co-authored-by: Cameron Miller <cammlle@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ros2action] Calling cancel even after successful execution
2 participants