Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abort pkg create if destination directory exists #258

Merged
merged 2 commits into from
May 24, 2019

Conversation

dirk-thomas
Copy link
Member

Fixes #256.

@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels May 23, 2019
@dirk-thomas dirk-thomas self-assigned this May 23, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/abort-create-if-exists branch from 60fc996 to be4e4b1 Compare May 23, 2019 20:22
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas
Copy link
Member Author

@clalancette I will go ahead and merge this without your review in order to include this fix in the nightly builds. Please review the PR anyway even after it was merged.

@dirk-thomas dirk-thomas merged commit dbd2c0d into master May 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/abort-create-if-exists branch May 24, 2019 04:00
@clalancette
Copy link
Contributor

I can't hit "Approve" on already merged PRs, so I'll just say "Looks good to me".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ros2 pkg create can destroy work
2 participants