Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python3-argcomplete #26

Merged
merged 1 commit into from
Jun 27, 2017
Merged

support python3-argcomplete #26

merged 1 commit into from
Jun 27, 2017

Conversation

dirk-thomas
Copy link
Member

Check for Python 3 variation of bash function first.

Fixes #25.

Ready for review.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jun 27, 2017
@dirk-thomas dirk-thomas self-assigned this Jun 27, 2017
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that did it for me. Thanks.

@dirk-thomas dirk-thomas merged commit dace3ce into master Jun 27, 2017
@dirk-thomas dirk-thomas deleted the support_argcomplete_py3 branch June 27, 2017 20:22
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jun 27, 2017
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
* Add custom LaunchTestRunner with ROS specific preamble.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Please flake8 on launch_testing_ros

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants