-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'service find' verb #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
dirk-thomas
reviewed
Jun 7, 2019
Signed-off-by: artivis <jeremie.deray@canonical.com>
dirk-thomas
reviewed
Jun 7, 2019
Signed-off-by: artivis <jeremie.deray@canonical.com>
dirk-thomas
reviewed
Jun 7, 2019
Signed-off-by: artivis <jeremie.deray@canonical.com>
@dirk-thomas Genuine question, is there a way to run the CI locally ?? A docker or such ? |
There are two options:
|
I did setup a workspace following the instructions but tests are still passing. I guess I'm missing some linter-related pkgs.
I'll look into that thanks 👍 |
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Made a separate module, accepts a single topic Signed-off-by: Aditya Pande <aditya050995@gmail.com> * Support for multiple topics Signed-off-by: Aditya Pande <aditya050995@gmail.com> * Spin in a separate context Signed-off-by: Aditya Pande <aditya050995@gmail.com> * Added magic methods Signed-off-by: Aditya Pande <aditya050995@gmail.com> * Review changes Signed-off-by: Aditya Pande <aditya050995@gmail.com> * Removed mutex Signed-off-by: Aditya Pande <aditya050995@gmail.com> * Added RuntimeError info Signed-off-by: Aditya Pande <aditya050995@gmail.com> * Changed docstring Signed-off-by: Aditya Pande <aditya050995@gmail.com> * Changed docstring Signed-off-by: Aditya Pande <aditya050995@gmail.com> * Added test case Signed-off-by: Aditya Pande <aditya050995@gmail.com> * Review changes Signed-off-by: Aditya Pande <aditya050995@gmail.com>
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
find
verb toservice
which lists all services of a given type.E.g.
given
ros2 run demo_nodes_cpp talker
&ros2 run demo_nodes_cpp listener
or with count-topics option,