Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'service find' verb #274

Merged
merged 6 commits into from
Jun 10, 2019
Merged

Conversation

artivis
Copy link
Contributor

@artivis artivis commented Jun 7, 2019

Add the find verb to service which lists all services of a given type.
E.g.
given ros2 run demo_nodes_cpp talker & ros2 run demo_nodes_cpp listener

$ ros2 service find rcl_interfaces/srv/ListParameters
/listener/list_parameters
/talker/list_parameters

or with count-topics option,

$ ros2 service find rcl_interfaces/srv/ListParameters -c
2

Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis
Copy link
Contributor Author

artivis commented Jun 10, 2019

@dirk-thomas Genuine question, is there a way to run the CI locally ?? A docker or such ?

@dirk-thomas
Copy link
Member

is there a way to run the CI locally ?? A docker or such ?

There are two options:

@dirk-thomas
Copy link
Member

Thanks for the feature addition.

Build Status

@dirk-thomas dirk-thomas added the enhancement New feature or request label Jun 10, 2019
@dirk-thomas dirk-thomas merged commit b30fbbf into ros2:master Jun 10, 2019
@artivis
Copy link
Contributor Author

artivis commented Jun 10, 2019

  • If your developer machine is setup according to the instructions you should get the same result if you ran the test using colcon test --packages-select <pkgname>.

I did setup a workspace following the instructions but tests are still passing. I guess I'm missing some linter-related pkgs.

I'll look into that thanks 👍

@artivis artivis deleted the feature/service_find branch June 10, 2019 18:06
@kyrofa kyrofa mentioned this pull request Sep 4, 2019
34 tasks
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
* Made a separate module, accepts a single topic

Signed-off-by: Aditya Pande <aditya050995@gmail.com>

* Support for multiple topics

Signed-off-by: Aditya Pande <aditya050995@gmail.com>

* Spin in a separate context

Signed-off-by: Aditya Pande <aditya050995@gmail.com>

* Added magic methods

Signed-off-by: Aditya Pande <aditya050995@gmail.com>

* Review changes

Signed-off-by: Aditya Pande <aditya050995@gmail.com>

* Removed mutex

Signed-off-by: Aditya Pande <aditya050995@gmail.com>

* Added RuntimeError info

Signed-off-by: Aditya Pande <aditya050995@gmail.com>

* Changed docstring

Signed-off-by: Aditya Pande <aditya050995@gmail.com>

* Changed docstring

Signed-off-by: Aditya Pande <aditya050995@gmail.com>

* Added test case

Signed-off-by: Aditya Pande <aditya050995@gmail.com>

* Review changes

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
…#276)

This reverts commit bbcc0cc.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants