Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2param: consider automatic declaration for 'use_sim_time' #307

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Jul 29, 2019

Connected to ros2/rclpy#396; this fix is needed for CI to pass.

Signed-off-by: Juan Ignacio Ubeira jubeira@ekumenlabs.com

…of 'use_sim_time' parameter.

Signed-off-by: Juan Ignacio Ubeira <jubeira@ekumenlabs.com>
@jubeira
Copy link
Contributor Author

jubeira commented Jul 30, 2019

CI (from ros2/rclpy#396 (comment)):

  • Linux: Build Status
  • Linux-aarch64: Build Status
  • OSX: Build Status
  • Windows: Build Status

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jubeira
Copy link
Contributor Author

jubeira commented Jul 30, 2019

Failures are unrelated known issues; merging now!

@jubeira jubeira merged commit f8afbed into master Jul 30, 2019
@jubeira jubeira deleted the jubeira/#395_declare_sim_time branch July 30, 2019 21:34
@jubeira jubeira moved this from Proposed to Needs Backport in Dashing Patch Release 2 Jul 30, 2019
skucheria pushed a commit that referenced this pull request Jul 30, 2019
…of 'use_sim_time' parameter. (#307)

Signed-off-by: Juan Ignacio Ubeira <jubeira@ekumenlabs.com>
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
Use the newer select interface where available, but fallback
to the dict interface as needed.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants