Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing ifcfg_vendor #323

Merged
merged 1 commit into from Aug 28, 2019
Merged

removing ifcfg_vendor #323

merged 1 commit into from Aug 28, 2019

Conversation

claireyywang
Copy link
Contributor

@claireyywang claireyywang commented Aug 28, 2019 •
edited

Removing ifcfg_vendor from build dependency to prevent breaking master build. Will add it later for the network check after a .deb package is ready.

@claireyywang claireyywang self-assigned this Aug 28, 2019
@claireyywang
Copy link
Contributor Author

Linux Build Status
Linux-aarch64 Build Status
OSX Build Status
Windows Build Status

sloretz
sloretz approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as a temporary fix.

@claireyywang claireyywang merged commit aa48ac8 into master Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the claire/revert-ifcfg-dependency branch August 28, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

Assignees

@claireyywang claireyywang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@claireyywang @sloretz