Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2doctor: add --include-warning arg #338

Merged
merged 5 commits into from
Sep 25, 2019

Conversation

claireyywang
Copy link
Contributor

Adds arg --include-warning/-iw to ros2doctor CLI. It reports both warnings and errors as failed checks, while the default only includes errors. It can be used in combination with --report-failed/-rf or by itself when running ros2 doctor checks. It lets users choose how extensive the checks and reports cover.

claireyywang added 3 commits September 23, 2019 14:17
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
@claireyywang claireyywang added the in review Waiting for review (Kanban column) label Sep 24, 2019
@claireyywang claireyywang self-assigned this Sep 24, 2019
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
@claireyywang claireyywang merged commit 80bd1ed into master Sep 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the claire/add-include-warning-arg branch September 25, 2019 16:59
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants