-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add completion for parameter name arguments #364
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My sole concern is response latency. How long does it take to provide suggestions? I ask because I've seen ros2 topic
almost blocking while retrieving topics. DirectNode
brings up a node on construction and tears it down on context leave -- maybe keeping it around may speed up subsequent queries, not the first though.
Also, why not adding completion for the set
verb?
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
It takes as long as it takes to spin up the node and wait for the service.
In this case the delay happens when you use completion. If you don't it doesn't affect the call.
It would be great if instead this information would be queried over the
Added in 96bee44. |
Yeah, that's what I was thinking of. Alright, food for thought. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For the
get
anddelete
verbs. Also naming the argumentparameter_name
(rather thanname
) in the usage.