Skip to content

Commit

Permalink
add parameter name completion for set
Browse files Browse the repository at this point in the history
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
  • Loading branch information
dirk-thomas committed Oct 17, 2019
1 parent 65ba068 commit 96bee44
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions ros2param/ros2param/verb/set.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from ros2node.api import NodeNameCompleter
from ros2param.api import call_set_parameters
from ros2param.api import get_parameter_value
from ros2param.api import ParameterNameCompleter
from ros2param.verb import VerbExtension


Expand All @@ -38,8 +39,9 @@ def add_arguments(self, parser, cli_name): # noqa: D102
parser.add_argument(
'--include-hidden-nodes', action='store_true',
help='Consider hidden nodes as well')
parser.add_argument(
'name', help='Name of the parameter')
arg = parser.add_argument(
'parameter_name', help='Name of the parameter')
arg.completer = ParameterNameCompleter()
parser.add_argument(
'value', help='Value of the parameter')

Expand All @@ -54,7 +56,7 @@ def main(self, *, args): # noqa: D102

with DirectNode(args) as node:
parameter = Parameter()
Parameter.name = args.name
Parameter.name = args.parameter_name
parameter.value = get_parameter_value(string_value=args.value)

response = call_set_parameters(
Expand Down

0 comments on commit 96bee44

Please sign in to comment.