Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2doctor] Check for deprecated packages #388

Merged
merged 20 commits into from
Dec 6, 2019

Conversation

claireyywang
Copy link
Contributor

@claireyywang claireyywang commented Oct 25, 2019

Closes feature request on #343, this PR checks locally installed package versions against ones on rosdistro, and warns users about deprecated packages. Rebased PR from #356.

Expected output of ros2 doctor in Eloquent:

$ ros2 doctor
/home/claire/ros2_eloquent/install/ros2doctor/lib/python3.6/site-packages/ros2doctor/api/format.py: 76: UserWarning: Cannot find required versions of packages: yaml_cpp_vendor ros1_bridge interactive_markers robot_state_publisher kdl_parser urdf turtlesim rqt_top rqt_srv rqt_shell rqt_service_caller rqt_reconfigure rqt_py_console rqt_publisher rqt_plot rqt_msg rqt_console rqt_graph rclpy example_interfaces unique_identifier_msgs uncrustify_vendor laser_geometry tlsf pluginlib test_security test_rclcpp test_quality_of_service test_launch_testing test_launch_ros test_interface_files test_communication test_cli_remapping test_cli spdlog_vendor rmw_implementation rosidl_runtime_py ros_environment rcutils rcpputils python_qt_binding python_cmake_module class_loader osrf_pycommon message_filters libyaml_vendor eigen3_cmake_module console_bridge_vendor ament_package

All 4 checks passed

Expected output of ros2 doctor -r in Eloquent:

  PACKAGE VERSIONS
rviz_visual_testing_framework             : required=7.0.3, local=7.0.3
rviz2                                     : required=7.0.3, local=7.0.3
rviz_default_plugins                      : required=7.0.3, local=7.0.3
rviz_common                               : required=7.0.3, local=7.0.3
ros2bag                                   : required=0.2.4, local=0.2.4
rosbag2_transport                         : required=0.2.4, local=0.2.4
rosbag2_storage_default_plugins           : required=0.2.4, local=0.2.4
rosbag2_converter_default_plugins         : required=0.2.4, local=0.2.4
rosbag2                                   : required=0.2.4, local=0.2.4
rosbag2_storage                           : required=0.2.4, local=0.2.4
yaml_cpp_vendor                           : required=, local=7.0.0
ros1_bridge                               : required=, local=0.8.1
interactive_markers                       : required=, local=2.0.1
common_interfaces                         : required=0.8.1, local=0.8.1
visualization_msgs                        : required=0.8.1, local=0.8.1
dummy_robot_bringup                       : required=0.8.4, local=0.8.4
robot_state_publisher                     : required=, local=2.3.1
kdl_parser                                : required=, local=2.2.0
urdf                                      : required=, local=2.2.0
turtlesim                                 : required=, local=1.1.0

Signed-off-by: claireyywang <clairewang@openrobotics.org>
@claireyywang claireyywang added the in review Waiting for review (Kanban column) label Oct 25, 2019
@claireyywang claireyywang self-assigned this Oct 25, 2019
@claireyywang
Copy link
Contributor Author

@tfoote in case you're interested

claireyywang added 12 commits November 19, 2019 11:56
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Show resolved Hide resolved
Claire Wang and others added 4 commits December 2, 2019 15:38
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
…ction

Signed-off-by: claireyywang <clairewang@openrobotics.org>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done another pass.

ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
claireyywang added 2 commits December 4, 2019 14:36
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI. Two minor suggestions.

ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
ros2doctor/ros2doctor/api/package.py Outdated Show resolved Hide resolved
Signed-off-by: claireyywang <clairewang@openrobotics.org>
@claireyywang
Copy link
Contributor Author

Linux Build Status
LInux-aarch64 Build Status
OSX Build Status
Windows Build Status

@claireyywang claireyywang merged commit b5349ee into master Dec 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the claire/check-package-version branch December 6, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants