Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add service clients to ros2node info #392

Merged
merged 1 commit into from
Nov 11, 2019
Merged

add service clients to ros2node info #392

merged 1 commit into from
Nov 11, 2019

Conversation

mikaelarguedas
Copy link
Member

Currently ros2 node info shows only service servers:

$ ros2 run demo_nodes_py add_two_ints_client &
$ ros2 node info /add_two_ints_client
/add_two_ints_client
  Subscribers:

  Publishers:
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /rosout: rcl_interfaces/msg/Log
  Services:
    /add_two_ints_client/describe_parameters: rcl_interfaces/srv/DescribeParameters
    /add_two_ints_client/get_parameter_types: rcl_interfaces/srv/GetParameterTypes
    /add_two_ints_client/get_parameters: rcl_interfaces/srv/GetParameters
    /add_two_ints_client/list_parameters: rcl_interfaces/srv/ListParameters
    /add_two_ints_client/set_parameters: rcl_interfaces/srv/SetParameters
    /add_two_ints_client/set_parameters_atomically: rcl_interfaces/srv/SetParametersAtomically
  Action Servers:

  Action Clients:

After this PR:

$ ros2 run demo_nodes_py add_two_ints_client &
$ ros2 node info /add_two_ints_client
$ ros2 node info /add_two_ints_client
/add_two_ints_client
  Subscribers:

  Publishers:
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /rosout: rcl_interfaces/msg/Log
  Service Servers:
    /add_two_ints_client/describe_parameters: rcl_interfaces/srv/DescribeParameters
    /add_two_ints_client/get_parameter_types: rcl_interfaces/srv/GetParameterTypes
    /add_two_ints_client/get_parameters: rcl_interfaces/srv/GetParameters
    /add_two_ints_client/list_parameters: rcl_interfaces/srv/ListParameters
    /add_two_ints_client/set_parameters: rcl_interfaces/srv/SetParameters
    /add_two_ints_client/set_parameters_atomically: rcl_interfaces/srv/SetParametersAtomically
  Service Clients:
    /add_two_ints: example_interfaces/srv/AddTwoInts
  Action Servers:

  Action Clients:

Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com

@mikaelarguedas
add service clients to ros2node info
66748eb 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
hidmic
hidmic approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@hidmic
Copy link
Contributor

hidmic commented Nov 11, 2019

CI up to ros2node and ros2component:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

mjcarroll
mjcarroll approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic
Copy link
Contributor

hidmic commented Nov 11, 2019

@mjcarroll test failures on the Eloquent job seem unrelated, merge?

@mjcarroll mjcarroll merged commit e020486 into ros2:master Nov 11, 2019
@mikaelarguedas mikaelarguedas deleted the ros2node_service_client branch November 11, 2019 21:27
jaisontj pushed a commit to aws-ros-dev/ros2cli that referenced this pull request Nov 14, 2019
@mikaelarguedas @jaisontj
add service clients to ros2node info (ros2#392)
3641338 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@dirk-thomas dirk-thomas mentioned this pull request Nov 26, 2019
Closed
dirk-thomas pushed a commit that referenced this pull request Nov 27, 2019
@mikaelarguedas @dirk-thomas
add service clients to ros2node info (#392)
10d1dd2 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
dirk-thomas pushed a commit that referenced this pull request Nov 27, 2019
@mikaelarguedas @dirk-thomas
add service clients to ros2node info (#392)
91aec87 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@dirk-thomas dirk-thomas mentioned this pull request Nov 27, 2019
Merged
dirk-thomas pushed a commit that referenced this pull request Nov 27, 2019
@mikaelarguedas @dirk-thomas
add service clients to ros2node info (#392)
ccbbfed 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
dirk-thomas added a commit that referenced this pull request Nov 27, 2019
@dirk-thomas
add service clients to ros2node info (#392) (#409)
b0a4b1a 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
dirk-thomas added a commit that referenced this pull request Dec 4, 2019
@dirk-thomas
Revert "add service clients to ros2node info (#392) (#409)"
3a455f3 
This reverts commit b0a4b1a.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas added a commit that referenced this pull request Dec 5, 2019
@dirk-thomas
partially revert [dashing backport] add service clients to ros2node i…
ec589d9 
…nfo (#418)

* Revert "add service clients to ros2node info (#392) (#409)"

This reverts commit b0a4b1a.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* readd get_service_server_info API for cross distro compatibility

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@hidmic hidmic hidmic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikaelarguedas @hidmic @mjcarroll