Update network check to fix missing flags on Windows #404
Conversation
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
|
@ros-pull-request-builder retest this please |
|
Linux |
ros2doctor/ros2doctor/api/network.py
Outdated
| @@ -66,6 +66,11 @@ def check(self): | |||
| return result | |||
|
|
|||
| has_loopback, has_non_loopback, has_multicast = _check_network_config_helper(ifcfg_ifaces) | |||
| if not has_loopback and not has_non_loopback: | |||
There was a problem hiding this comment.
I would make this warning only happen on windows since it would be an actual error on other platforms if both of these were False. One way is to make this line check if the platform is windows. Another way would be to make _check_network_config_helper() return None for these values instead of True or False when there's no information, and then check if they're None here.
ros2doctor/ros2doctor/api/network.py
Outdated
| @@ -66,6 +66,11 @@ def check(self): | |||
| return result | |||
|
|
|||
| has_loopback, has_non_loopback, has_multicast = _check_network_config_helper(ifcfg_ifaces) | |||
| if not has_loopback and not has_non_loopback: | |||
| # no flags found, otherwise one of them should be True. | |||
| result.add_warning('No flags found. \ | |||
There was a problem hiding this comment.
I'm not sure if it should be a warning in the result since there's nothing a user can do to resolve it. Maybe this should be printed, or maybe result should have an even softer category like result.add_note()?
There was a problem hiding this comment.
I think this scenario is rare (or I would like to keep it rare) enough to use a print statement instead of extending the result category, but good point and I will modify it.
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Good catch! |
Signed-off-by: claireyywang <clairewang@openrobotics.org>
ros2doctor/ros2doctor/api/network.py
Outdated
| @@ -36,7 +36,7 @@ def _is_unix_like_platform() -> bool: | |||
| def _check_network_config_helper(ifcfg_ifaces: dict) -> Tuple[bool, bool, bool]: | |||
| """Check if loopback and multicast IP addresses are found.""" | |||
| has_loopback, has_non_loopback, has_multicast = False, False, False | |||
| for _, iface in ifcfg.interfaces().items(): | |||
| for _, iface in ifcfg_ifaces.items(): | |||
There was a problem hiding this comment.
If you don't need the keys instead of calling .items() call .values().
Same below.
Signed-off-by: claireyywang <clairewang@openrobotics.org>
|
Linux |
Warn about missing flags on windows
ipconfigoutput. Closes #403 - false negative warnings on windows.