Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ros2action] Refactor send_goal implementation #406

Merged
merged 2 commits into from
Dec 9, 2019
Merged

[ros2action] Refactor send_goal implementation #406

merged 2 commits into from
Dec 9, 2019

Conversation

jacobperron
Copy link
Member

Resolve a TODO and use a function from rosidl_runtime_py to get the action interface.

Connects to #218

@jacobperron
[ros2action] Refactor send_goal implementation
19e75c4 
Resolve a TODO and use a function from rosidl_runtime_py to get the action interface.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron self-assigned this Nov 25, 2019
@jacobperron jacobperron mentioned this pull request Nov 25, 2019
Closed
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Nov 25, 2019
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 6, 2019
@jacobperron
Copy link
Member Author

jacobperron commented Dec 6, 2019 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

edit: doh 670e83e

@jacobperron
fix lint
670e83e 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added the enhancement New feature or request label Dec 6, 2019
hidmic
hidmic approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobperron jacobperron merged commit 876c46c into master Dec 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/refactor_send_goal branch December 9, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@jacobperron jacobperron

Labels
enhancement New feature or request in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobperron @hidmic