[ros2param] Add timeout to ros2param list #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Donghee Ye <donghee.ye@samsung.com>
| @@ -87,7 +87,7 @@ def main(self, *, args): # noqa: D102 | |||
|
|
|||
| # wait for all responses | |||
| for future in futures.values(): | |||
| rclpy.spin_until_future_complete(node, future) | |||
| rclpy.spin_until_future_complete(node, future, timeout_sec=1.0) | |||
There was a problem hiding this comment.
not sure just ignoring timeout is good enough here. i would add check the FutureReturnCode, and if gets TIMEOUT, notify the user what node's parameter cannot be queried. i would like to hear from others.
There was a problem hiding this comment.
I agree, if there is a problem communicating with one of the parameter servers then we should warn the user, but I think we are getting some feedback with the "exception" printed at L104.
jacobperron
approved these changes
Apr 8, 2020
| @@ -87,7 +87,7 @@ def main(self, *, args): # noqa: D102 | |||
|
|
|||
| # wait for all responses | |||
| for future in futures.values(): | |||
| rclpy.spin_until_future_complete(node, future) | |||
| rclpy.spin_until_future_complete(node, future, timeout_sec=1.0) | |||
There was a problem hiding this comment.
I agree, if there is a problem communicating with one of the parameter servers then we should warn the user, but I think we are getting some feedback with the "exception" printed at L104.
The warnings are unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the node use default node option ( start_parameter_services is ture) and use not spin() but spin_until_future_complete(), then ros2param list send a request to the node but the callback of parameter service list parameter request can not be called. and ros2param spin_until_future_complete can not be finished.