[ros2param] Wait for discovery before running tests #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #480. Catch expected exceptions from rclpy (or transitively as xmlrpc.client.Fault) while we wait for discovery in the test setup. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
nuclearsandwich
approved these changes
Apr 9, 2020
ivanpauno
approved these changes
Apr 9, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Edit: unrelated warnings |
jacobperron
added a commit
that referenced
this pull request
Apr 14, 2020
Follow-up to #481 This makes the tests faster. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
commented
Apr 14, 2020
jacobperron
added a commit
that referenced
this pull request
Apr 15, 2020
Follow-up to #481 This makes the tests faster. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480.
Catch expected exceptions from rclpy (or transitively as xmlrpc.client.Fault) while we wait for discovery in the test setup.