Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ros2param] Do not wait for entire timeout in test_verb_dump setUp #486

Merged
merged 1 commit into from
Apr 15, 2020
Merged

[ros2param] Do not wait for entire timeout in test_verb_dump setUp #486

merged 1 commit into from
Apr 15, 2020

Conversation

jacobperron
Copy link
Member

Follow-up to #481

This makes the tests faster.

@jacobperron jacobperron mentioned this pull request Apr 14, 2020
Merged
@jacobperron
Copy link
Member Author

Testing ros2param:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron mentioned this pull request Apr 14, 2020
Merged
@jacobperron
Do not wait for entire timeout
2618e79 
Follow-up to #481

This makes the tests faster.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron merged commit ff5a756 into master Apr 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/break_after_discovery branch April 15, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobperron @ivanpauno