Skip CLI tests on Windows until we resolve the blocking/hanging isuse. #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been lacking on Windows test data for months due to the blocking or hung state that these tests can get into. I think the best thing to do is skip these tests on windows to allow other builds to complete while we continue investigating the problem. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
|
CI up to these packages and testing them. On Windows I want to check that the CLI tests are skipped and on other platforms I want to verify that they run as expected.
|
jacobperron
approved these changes
Apr 15, 2020
|
I'm pretty sure the test failures above were introduced by ros2/rclpy#536 (discussion). I am going to merge in order to improve the situation on Windows. |
|
Please ticket the follow up task to revert this change. |
Do you feel an issue separate from ros2/build_farmer#248 is warranted? |
|
I would be concerned that the task of reverting this change gets lost in the length and broader scope of that ticket. |
|
jacobperron
added a commit
that referenced
this pull request
Apr 16, 2020
Other CLI tests are skipped on Windows since #489. To be reverted when ros2/build_farmer#248 is resolved. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Apr 16, 2020
Other CLI tests are skipped on Windows since #489. To be reverted when ros2/build_farmer#248 is resolved. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Apr 18, 2020
Fixes #480 The actual tests are the same, except with the use of launch_testing we ensure the CLI daemon is restarted between tests. This follows a similar pattern as the other ros2cli tests. In addition to converting to launch tests, this change also runs the tests for all RMW implementations. For now, we are skipping tests on Windows. Other CLI tests are skipped on Windows since #489. To be reverted when ros2/build_farmer#248 is resolved. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been lacking on Windows test data for months due to the blocking
or hung state that these tests can get into. I think the best thing to
do is skip these tests on windows to allow other builds to complete
while we continue investigating the problem.
I've opted for skipping entire test modules as I think the underlying issue is in the test apparatus rather than any specific test.