Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error message when trying to stop a daemon using a different rmw implementation #49

Merged
merged 1 commit into from
Sep 11, 2017

Conversation

dirk-thomas
Copy link
Member

Instead of showing a stacktrace with the following exception:

AttributeError: 'Node' object has no attribute 'system'

this patch prints an error message describing why it failed.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Sep 11, 2017
@dirk-thomas dirk-thomas self-assigned this Sep 11, 2017
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 👍

@dirk-thomas dirk-thomas merged commit d52688c into master Sep 11, 2017
@dirk-thomas dirk-thomas deleted the msg_stopping_daemon_diff_rmw branch September 11, 2017 23:40
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Sep 11, 2017
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
* add flake8 test

* fix flake8 violations

* remove redundant pep8 pyflakes tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants