Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid array.array in ros2 param output. #508

Merged
merged 1 commit into from
May 15, 2020
Merged

Avoid array.array in ros2 param output. #508

merged 1 commit into from
May 15, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented May 12, 2020

Precisely what the title says. Otherwise parameter YAML dumps won't be load by rcl. Also, I think it looks better if we avoid !!python/object/apply:array.array altogether.

@hidmic
Avoid array.array in ros2 param output.
3d8bee5 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from jacobperron May 12, 2020 20:50
@hidmic hidmic added the enhancement New feature or request label May 12, 2020
@hidmic
Copy link
Contributor Author

hidmic commented May 12, 2020

CI up to ros2param:

  • Linux Build Status

jacobperron
jacobperron approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic
Copy link
Contributor Author

hidmic commented May 15, 2020

Alright going in.

@hidmic hidmic merged commit 428e150 into master May 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/no-python-types-in-yaml branch May 15, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hidmic @jacobperron