Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

param list -t for consistency #569

Closed
JuliusSustarevas opened this issue Oct 10, 2020 · 5 comments
Closed

param list -t for consistency #569

JuliusSustarevas opened this issue Oct 10, 2020 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@JuliusSustarevas
Copy link

#96 Feature request
ros2 topic list
and
ros2 service list
have the -t parameter to show types. But ros2 param list does not. It would be convinient and consistent if it did.

Feature description

"ros2 param list -t" could return param names followed by types

@clalancette
Copy link
Contributor

"ros2 param list -t" could return param names followed by types

While I like the idea of the feature, I think we may want to use a different flag than -t. The -t flag implicitly means print the ROS message type, which is not what you are asking for. Instead, you are asking for the internal stored type of the parameters. I'll just throw out --param-type as a flag idea for now, but maybe others disagree.

In any case, while I think this is a great idea, I don't think we're going to have time to work on it right now. But if you'd like to contribute a change to add it, we'd be happy to review it.

Thanks for the report.

@clalancette clalancette added the help wanted Extra attention is needed label Oct 11, 2020
@JuliusSustarevas
Copy link
Author

Well I personally always wanted params to be ROS Message type which gives a certain nice consistency. You could set some param as a Pose message, set your deadzone speed as a Twist Message etc. But thats a separate feature request i guess

@fujitatomoya
Copy link
Collaborator

@clalancette

since this is tagged with help wanted, i did come up with quick candidate. could you take a look at #572?

@fujitatomoya
Copy link
Collaborator

@clalancette

friengly ping, i think we can close this.

@clalancette
Copy link
Contributor

Closing since #572 is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants