Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --filter options for 'ros2 param list' #592

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Add --filter options for 'ros2 param list' #592

merged 2 commits into from
Feb 19, 2021

Conversation

ivanpauno
Copy link
Member

Examples:

ros2 param list --filter '(?!qos_overrides)'
ros2 param list --filter 'prefix_for_group_of_settings_i_care.*'

I'm not sure if we want exactly this or something else...

TODO: tests

@ivanpauno
Add --filter options for 'ros2 param list'
e9d93c5 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Jan 29, 2021
@ivanpauno ivanpauno self-assigned this Jan 29, 2021
fujitatomoya
fujitatomoya reviewed Jan 31, 2021
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is useful with and w/o --param-prefixes

@ivanpauno
Copy link
Member Author

@jacobperron friendly ping

jacobperron
jacobperron reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after adding some unit tests.

@ivanpauno
Add tests for 'ros2 param list'
13a4eed 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

jacobperron
jacobperron approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests, LGTM

@ivanpauno ivanpauno merged commit c453417 into master Feb 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/filter-for-ros2-param-list branch February 19, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@jacobperron jacobperron jacobperron approved these changes

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanpauno @jacobperron @fujitatomoya