Use target_compile_features for c/c++ standards

[sloretz]

Commands used to test

ros2 pkg create --build-type cmake --node-name foo cmake_node
ros2 pkg create --build-type cmake --library-name bar cmake_lib
ros2 pkg create --build-type cmake --node-name foo --library-name bar cmake_node_and_lib
ros2 pkg create --build-type ament_cmake --node-name foo --library-name bar amentcmake_node_and_lib
ros2 pkg create --build-type ament_cmake --node-name foo amentcmake_node
ros2 pkg create --build-type ament_cmake --library-name bar amentcmake_lib

Build results

$ colcon build --event-handlers console_cohesion+
Starting >>> amentcmake_lib
Starting >>> amentcmake_node
Starting >>> amentcmake_node_and_lib
Starting >>> cmake_lib
Starting >>> cmake_node
Starting >>> cmake_node_and_lib
--- output: cmake_lib                                                                                                                                                                                                                   
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/ws/src/build/cmake_lib
Scanning dependencies of target bar
[ 50%] Building CXX object CMakeFiles/bar.dir/src/bar.cpp.o
[100%] Linking CXX shared library libbar.so
[100%] Built target bar
-- Install configuration: ""
-- Installing: /tmp/ws/src/install/cmake_lib/include
-- Installing: /tmp/ws/src/install/cmake_lib/include/cmake_lib
-- Installing: /tmp/ws/src/install/cmake_lib/include/cmake_lib/bar.hpp
-- Installing: /tmp/ws/src/install/cmake_lib/include/cmake_lib/visibility_control.h
-- Installing: /tmp/ws/src/install/cmake_lib/lib/libbar.so
-- Installing: /tmp/ws/src/install/cmake_lib/share/cmake_lib/cmake/cmake_libConfig.cmake
-- Installing: /tmp/ws/src/install/cmake_lib/share/cmake_lib/cmake/cmake_libConfigVersion.cmake
-- Installing: /tmp/ws/src/install/cmake_lib/share/cmake_lib/cmake/export_cmake_lib.cmake
-- Installing: /tmp/ws/src/install/cmake_lib/share/cmake_lib/cmake/export_cmake_lib-noconfig.cmake
---
Finished <<< cmake_lib [0.78s]
--- output: cmake_node
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/ws/src/build/cmake_node
Scanning dependencies of target foo
[ 50%] Building CXX object CMakeFiles/foo.dir/src/foo.cpp.o
[100%] Linking CXX executable foo
[100%] Built target foo
-- Install configuration: ""
-- Installing: /tmp/ws/src/install/cmake_node/lib/cmake_node/foo
-- Installing: /tmp/ws/src/install/cmake_node/share/cmake_node/cmake/cmake_nodeConfig.cmake
-- Installing: /tmp/ws/src/install/cmake_node/share/cmake_node/cmake/cmake_nodeConfigVersion.cmake
-- Installing: /tmp/ws/src/install/cmake_node/share/cmake_node/cmake/export_cmake_node.cmake
-- Installing: /tmp/ws/src/install/cmake_node/share/cmake_node/cmake/export_cmake_node-noconfig.cmake
---
Finished <<< cmake_node [0.77s]
--- output: cmake_node_and_lib                                                                                                                                           
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/ws/src/build/cmake_node_and_lib
Scanning dependencies of target bar
[ 25%] Building CXX object CMakeFiles/bar.dir/src/bar.cpp.o
[ 50%] Linking CXX shared library libbar.so
[ 50%] Built target bar
Scanning dependencies of target foo
[ 75%] Building CXX object CMakeFiles/foo.dir/src/foo.cpp.o
[100%] Linking CXX executable foo
[100%] Built target foo
-- Install configuration: ""
-- Installing: /tmp/ws/src/install/cmake_node_and_lib/include
-- Installing: /tmp/ws/src/install/cmake_node_and_lib/include/cmake_node_and_lib
-- Installing: /tmp/ws/src/install/cmake_node_and_lib/include/cmake_node_and_lib/bar.hpp
-- Installing: /tmp/ws/src/install/cmake_node_and_lib/include/cmake_node_and_lib/visibility_control.h
-- Installing: /tmp/ws/src/install/cmake_node_and_lib/lib/libbar.so
-- Installing: /tmp/ws/src/install/cmake_node_and_lib/lib/cmake_node_and_lib/foo
-- Set runtime path of "/tmp/ws/src/install/cmake_node_and_lib/lib/cmake_node_and_lib/foo" to ""
-- Installing: /tmp/ws/src/install/cmake_node_and_lib/share/cmake_node_and_lib/cmake/cmake_node_and_libConfig.cmake
-- Installing: /tmp/ws/src/install/cmake_node_and_lib/share/cmake_node_and_lib/cmake/cmake_node_and_libConfigVersion.cmake
-- Installing: /tmp/ws/src/install/cmake_node_and_lib/share/cmake_node_and_lib/cmake/export_cmake_node_and_lib.cmake
-- Installing: /tmp/ws/src/install/cmake_node_and_lib/share/cmake_node_and_lib/cmake/export_cmake_node_and_lib-noconfig.cmake
---
Finished <<< cmake_node_and_lib [0.86s]
--- output: amentcmake_node                                                                                                                     
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found ament_cmake: 1.1.3 (/home/osrf/ws/ros2/install/ament_cmake/share/ament_cmake/cmake)
-- Found PythonInterp: /usr/bin/python3 (found suitable version "3.8.5", minimum required is "3") 
-- Using PYTHON_EXECUTABLE: /usr/bin/python3
-- Found ament_lint_auto: 0.10.4 (/home/osrf/ws/ros2/install/ament_lint_auto/share/ament_lint_auto/cmake)
-- Added test 'copyright' to check source files copyright and LICENSE
-- Added test 'cppcheck' to perform static code analysis on C / C++ code
-- Configured cppcheck include dirs: $<BUILD_INTERFACE:/tmp/ws/src/amentcmake_node/include>
-- Configured cppcheck exclude dirs and/or files: 
-- Added test 'cpplint' to check C / C++ code against the Google style
-- Configured cpplint exclude dirs and/or files: 
-- Added test 'lint_cmake' to check CMake code style
-- Added test 'uncrustify' to check C / C++ code style
-- Configured uncrustify additional arguments: 
-- Added test 'xmllint' to check XML markup files
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/ws/src/build/amentcmake_node
Scanning dependencies of target foo
[ 50%] Building CXX object CMakeFiles/foo.dir/src/foo.cpp.o
[100%] Linking CXX executable foo
[100%] Built target foo
-- Install configuration: ""
-- Installing: /tmp/ws/src/install/amentcmake_node/lib/amentcmake_node/foo
-- Installing: /tmp/ws/src/install/amentcmake_node/share/ament_index/resource_index/package_run_dependencies/amentcmake_node
-- Installing: /tmp/ws/src/install/amentcmake_node/share/ament_index/resource_index/parent_prefix_path/amentcmake_node
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/environment/ament_prefix_path.sh
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/environment/ament_prefix_path.dsv
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/environment/path.sh
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/environment/path.dsv
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/local_setup.bash
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/local_setup.sh
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/local_setup.zsh
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/local_setup.dsv
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/package.dsv
-- Installing: /tmp/ws/src/install/amentcmake_node/share/ament_index/resource_index/packages/amentcmake_node
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/cmake/amentcmake_nodeConfig.cmake
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/cmake/amentcmake_nodeConfig-version.cmake
-- Installing: /tmp/ws/src/install/amentcmake_node/share/amentcmake_node/package.xml
---
Finished <<< amentcmake_node [1.84s]
--- output: amentcmake_lib                                                                                   
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found ament_cmake: 1.1.3 (/home/osrf/ws/ros2/install/ament_cmake/share/ament_cmake/cmake)
-- Found PythonInterp: /usr/bin/python3 (found suitable version "3.8.5", minimum required is "3") 
-- Using PYTHON_EXECUTABLE: /usr/bin/python3
-- Found ament_cmake_ros: 0.9.1 (/home/osrf/ws/ros2/install/ament_cmake_ros/share/ament_cmake_ros/cmake)
-- Found ament_lint_auto: 0.10.4 (/home/osrf/ws/ros2/install/ament_lint_auto/share/ament_lint_auto/cmake)
-- Added test 'copyright' to check source files copyright and LICENSE
-- Added test 'cppcheck' to perform static code analysis on C / C++ code
-- Configured cppcheck include dirs: $<BUILD_INTERFACE:/tmp/ws/src/amentcmake_lib/include>
-- Configured cppcheck exclude dirs and/or files: 
-- Added test 'cpplint' to check C / C++ code against the Google style
-- Configured cpplint exclude dirs and/or files: 
-- Added test 'lint_cmake' to check CMake code style
-- Added test 'uncrustify' to check C / C++ code style
-- Configured uncrustify additional arguments: 
-- Added test 'xmllint' to check XML markup files
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/ws/src/build/amentcmake_lib
Scanning dependencies of target bar
[ 50%] Building CXX object CMakeFiles/bar.dir/src/bar.cpp.o
[100%] Linking CXX shared library libbar.so
[100%] Built target bar
-- Install configuration: ""
-- Installing: /tmp/ws/src/install/amentcmake_lib/include
-- Installing: /tmp/ws/src/install/amentcmake_lib/include/amentcmake_lib
-- Installing: /tmp/ws/src/install/amentcmake_lib/include/amentcmake_lib/bar.hpp
-- Installing: /tmp/ws/src/install/amentcmake_lib/include/amentcmake_lib/visibility_control.h
-- Installing: /tmp/ws/src/install/amentcmake_lib/lib/libbar.so
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/environment/library_path.sh
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/environment/library_path.dsv
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/ament_index/resource_index/package_run_dependencies/amentcmake_lib
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/ament_index/resource_index/parent_prefix_path/amentcmake_lib
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/environment/ament_prefix_path.sh
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/environment/ament_prefix_path.dsv
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/environment/path.sh
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/environment/path.dsv
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/local_setup.bash
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/local_setup.sh
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/local_setup.zsh
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/local_setup.dsv
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/package.dsv
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/ament_index/resource_index/packages/amentcmake_lib
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/cmake/export_amentcmake_libExport.cmake
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/cmake/export_amentcmake_libExport-noconfig.cmake
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/cmake/ament_cmake_export_include_directories-extras.cmake
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/cmake/ament_cmake_export_libraries-extras.cmake
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/cmake/ament_cmake_export_targets-extras.cmake
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/cmake/amentcmake_libConfig.cmake
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/cmake/amentcmake_libConfig-version.cmake
-- Installing: /tmp/ws/src/install/amentcmake_lib/share/amentcmake_lib/package.xml
---
Finished <<< amentcmake_lib [1.93s]
--- output: amentcmake_node_and_lib
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found ament_cmake: 1.1.3 (/home/osrf/ws/ros2/install/ament_cmake/share/ament_cmake/cmake)
-- Found PythonInterp: /usr/bin/python3 (found suitable version "3.8.5", minimum required is "3") 
-- Using PYTHON_EXECUTABLE: /usr/bin/python3
-- Found ament_cmake_ros: 0.9.1 (/home/osrf/ws/ros2/install/ament_cmake_ros/share/ament_cmake_ros/cmake)
-- Found ament_lint_auto: 0.10.4 (/home/osrf/ws/ros2/install/ament_lint_auto/share/ament_lint_auto/cmake)
-- Added test 'copyright' to check source files copyright and LICENSE
-- Added test 'cppcheck' to perform static code analysis on C / C++ code
-- Configured cppcheck include dirs: $<BUILD_INTERFACE:/tmp/ws/src/amentcmake_node_and_lib/include>
-- Configured cppcheck exclude dirs and/or files: 
-- Added test 'cpplint' to check C / C++ code against the Google style
-- Configured cpplint exclude dirs and/or files: 
-- Added test 'lint_cmake' to check CMake code style
-- Added test 'uncrustify' to check C / C++ code style
-- Configured uncrustify additional arguments: 
-- Added test 'xmllint' to check XML markup files
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/ws/src/build/amentcmake_node_and_lib
Scanning dependencies of target bar
[ 25%] Building CXX object CMakeFiles/bar.dir/src/bar.cpp.o
[ 50%] Linking CXX shared library libbar.so
[ 50%] Built target bar
Scanning dependencies of target foo
[ 75%] Building CXX object CMakeFiles/foo.dir/src/foo.cpp.o
[100%] Linking CXX executable foo
[100%] Built target foo
-- Install configuration: ""
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/include
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/include/amentcmake_node_and_lib
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/include/amentcmake_node_and_lib/bar.hpp
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/include/amentcmake_node_and_lib/visibility_control.h
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/lib/libbar.so
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/lib/amentcmake_node_and_lib/foo
-- Set runtime path of "/tmp/ws/src/install/amentcmake_node_and_lib/lib/amentcmake_node_and_lib/foo" to ""
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/environment/library_path.sh
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/environment/library_path.dsv
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/ament_index/resource_index/package_run_dependencies/amentcmake_node_and_lib
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/ament_index/resource_index/parent_prefix_path/amentcmake_node_and_lib
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/environment/ament_prefix_path.sh
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/environment/ament_prefix_path.dsv
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/environment/path.sh
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/environment/path.dsv
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/local_setup.bash
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/local_setup.sh
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/local_setup.zsh
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/local_setup.dsv
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/package.dsv
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/ament_index/resource_index/packages/amentcmake_node_and_lib
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/cmake/export_amentcmake_node_and_libExport.cmake
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/cmake/export_amentcmake_node_and_libExport-noconfig.cmake
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/cmake/ament_cmake_export_include_directories-extras.cmake
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/cmake/ament_cmake_export_libraries-extras.cmake
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/cmake/ament_cmake_export_targets-extras.cmake
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/cmake/amentcmake_node_and_libConfig.cmake
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/cmake/amentcmake_node_and_libConfig-version.cmake
-- Installing: /tmp/ws/src/install/amentcmake_node_and_lib/share/amentcmake_node_and_lib/package.xml
---
Finished <<< amentcmake_node_and_lib [1.97s]

Summary: 6 packages finished [2.10s]

[wjwwood]

lgtm, I think it's a nice solution

[sloretz]

Also bumped to CMake 3.8 for the C and C++ features

https://cmake.org/cmake/help/v3.8/prop_gbl/CMAKE_C_KNOWN_FEATURES.html
https://cmake.org/cmake/help/v3.8/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html

[sloretz]

CI (build: --packages-up-to ros2pkg test: --packages-select ros2pkg)

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

lgtm.

we should highlight this change in the release notes as least.

[sloretz]

CMake warning on Windows is in Cyclonedds; merging.