Depend on rclcpp::rclcpp target #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Audrow Nash <audrow@hey.com>
Karsten1987
suggested changes
Apr 2, 2021
There was a problem hiding this comment.
I actually think this should be refactored.
You generally don't have to deal with include_directories or even direct cmake targets such as rclcpp::rclcpp.
you can get rid of all these calls by simply leveraging ament_target_dependencies(simple_lifecycle_node rclpp_lifecycle).
Also, I think you should not need to depend on rclcpp. rclcpp_lifecycle should technically export rclcpp and ament_target_dependencies ought to take care of the transitive deps.
|
I agree with @Karsten1987 let's try the |
Signed-off-by: Audrow Nash <audrow@hey.com>
Karsten1987
approved these changes
Apr 2, 2021
wjwwood
approved these changes
Apr 2, 2021
Signed-off-by: Audrow Nash <audrow@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ros2/rclcpp#1613, ros-visualization/rqt#246, and ament/googletest#15.