Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use target_compile_features() to require C++11 features #15

Merged
merged 2 commits into from
Apr 3, 2021
Merged

use target_compile_features() to require C++11 features #15

merged 2 commits into from
Apr 3, 2021

Conversation

sloretz
Copy link

@sloretz sloretz commented Apr 1, 2021

This is necessary for packages that don't globally set CMAKE_CXX_STANDARD.

CI OSX with change to rclcpp and this package Build Status

@wjwwood does your local OSX workspace build successfully with this change?

@sloretz
Use target_compile_features for cxx standard
009723f 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Require c++11 for gmock
7ef6001 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Apr 1, 2021
@sloretz sloretz mentioned this pull request Apr 1, 2021
Closed
wjwwood
wjwwood approved these changes Apr 1, 2021
View reviewed changes
Copy link

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach is likely to work, but I was hesitant to edit google* directly. But I guess that's actually fine.

lgtm, but I'll also try it locally.

Karsten1987
Karsten1987 approved these changes Apr 1, 2021
View reviewed changes
Copy link

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a good solution to me. I wonder if there's anything upstream we could fix?

@wjwwood
Copy link

wjwwood commented Apr 1, 2021

This works locally for me.

@sloretz sloretz mentioned this pull request Apr 1, 2021
Closed
@wjwwood
Copy link

wjwwood commented Apr 2, 2021

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

This was referenced Apr 2, 2021
Merged
Merged
@wjwwood
Copy link

wjwwood commented Apr 2, 2021

Waiting on CI here:

ros2/rclcpp#1598 (comment)

@wjwwood wjwwood merged commit f207710 into ros2 Apr 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the use_tgt_compile_features branch April 3, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloretz @wjwwood @Karsten1987