Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2pkg.api.create_package_environment: handle exports #619

Closed
tim-fan opened this issue Apr 8, 2021 · 2 comments · Fixed by #628
Closed

ros2pkg.api.create_package_environment: handle exports #619

tim-fan opened this issue Apr 8, 2021 · 2 comments · Fixed by #628
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tim-fan
Copy link
Contributor

tim-fan commented Apr 8, 2021

Feature request

Feature description

In brief, I'm requesting package.xml.em be updated to allow setting of export tags, and create_package_environment be updated to pass export tags from the package description to the template.

Background: I'm using ros2pkg.api to generate a package. Looking at create.py#L148, it looks as if I should be able to list package exports in the catkin_pkg.package.Package specification, and have them listed in the package.xml generated by create_package_environment. However it appears that create_package_environment ignores the package export field, and the template only sets the build_type export tag.

I found it slightly confusing that create.py#L148 sets this export field, even though it is completely ignored by create_package_environment

Implementation considerations

@audrow
Copy link
Member

audrow commented Apr 16, 2021

Hi @tim-fan, you're right: it is weird that the export field is set and then not used by create_package_environment. Feel free to make a pull request for this - you can @ me if you need any help or need a review.

@audrow audrow added enhancement New feature or request help wanted Extra attention is needed labels Apr 16, 2021
tim-fan added a commit to tim-fan/ros2cli that referenced this issue Apr 20, 2021
Signed-off-by: Tim Fanselow <tim.fanselow@gmail.com>
audrow pushed a commit that referenced this issue May 27, 2021
Signed-off-by: Tim Fanselow <tim.fanselow@gmail.com>
@audrow audrow linked a pull request May 28, 2021 that will close this issue
@audrow
Copy link
Member

audrow commented May 28, 2021

Closed with #628.

@audrow audrow closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants