Pass package exports to template in pkg create api (#619) #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Fanselow <tim.fanselow@gmail.com>
|
|
Oops, sorry for the delay. I lost track of this. Here's a fresh run of CI:
|
|
Thanks for the PR @tim-fan! Sorry for the long delay. |
|
No worries, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @audrow, here's my fix for #619.
I tested it with
pytest ros2pkg/test/test_cli.py, which checks that the build type is being written topackage.xmlsuccessfully (here) .I also confirmed manually that
package.xmllooked correct (indentation, spacing between lines looked good).Let me know if any further changes or tests are needed.