Fix how ros2 param interprets command-line arguments. #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
reviewed
Jan 3, 2022
audrow
approved these changes
Jan 4, 2022
|
@ros-pull-request-builder retest this please |
Basically ensure that we are *always* using the parsed yaml string, so that users can override types as appropriate. This makes it possible for users to specify something like: ros2 param set /node param '!!str off' for force a string to be "off" as opposed to having YAML intepret it as a boolean. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
After doing some additional testing, I found a bug in the code, so I fixed that and added a couple more tests. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
clalancette/fix-param-interpretation
branch
from
f839780
to
e1569a4
Compare
|
All right, I found some time to do additional testing. This led to a bug which I fixed, and I added more tests. I'm going to mark this as ready for review and run CI on it. |
|
CI:
|
|
I'm going to go ahead and merge this with green CI. See ros2/ros2_documentation#2212 for documentation about this feature. |
delete-merged-branch
bot
deleted the
clalancette/fix-param-interpretation
branch
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically ensure that we are always using the parsed yaml
string, so that users can override types as appropriate.
This makes it possible for users to specify something like:
ros2 param set /node param '!!str off'
for force a string to be "off" as opposed to having YAML
intepret it as a boolean.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This is still a draft because I'm kind of nervous about the change; this has the potential to break some use-cases that worked before. All of the tests pass, and basic testing here has worked fine for me, but I want to do more testing before marking it as ready.
Fixes #677 (at least, as far as I think we can fix it)