Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced ros2 topic info to display node name, node namespace, topic type and qos profile of the publishers and subscribers. #385

Merged
merged 10 commits into from
Feb 27, 2020
Merged

Enhanced ros2 topic info to display node name, node namespace, topic type and qos profile of the publishers and subscribers. #385

merged 10 commits into from
Feb 27, 2020

Commits on Feb 14, 2020

  1. Enhanced ros2 topic info to display node name, node namespace, 

    topic type, gid and qos profile of the publishers and subscribers.

Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    adc7573 View commit details
    Browse the repository at this point in the history

  2. Added a --verbose flag to display the additional details and error 

    handling for cases when the underlying rmw_implementation may not have
implemented the functions.

Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    1c84126 View commit details
    Browse the repository at this point in the history

  3. Modified print of gid since it is no longer a string and is now an array 

    Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    8719059 View commit details
    Browse the repository at this point in the history

  4. Modified output of gid to use hexadecimals. 

    Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    d7f9f1e View commit details
    Browse the repository at this point in the history

  5. address PR comments 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    82ccf71 View commit details
    Browse the repository at this point in the history

  6. fix pre-existing unit test failures 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    73caa5c View commit details
    Browse the repository at this point in the history

  7. add test_info_topic_verbose() 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    4522188 View commit details
    Browse the repository at this point in the history

  8. rename *topic_info* to *topic_endpoint_info* 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    3906022 View commit details
    Browse the repository at this point in the history

  9. make use of TopicEndpointInfo objects 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    2efa973 View commit details
    Browse the repository at this point in the history

  10. rename variable to from lineend to line_end 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    4c6eaec View commit details
    Browse the repository at this point in the history