Better to use uri= constructor

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
ros2 · Dec 3, 2021 · 48b2b24 · 48b2b24
1 parent 6ee730f
commit 48b2b24
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/ros2bag/ros2bag/verb/convert.py b/ros2bag/ros2bag/verb/convert.py
@@ -42,8 +42,7 @@ def main(self, *, args):
             if len(input_bag) > 2:
                 raise argparse.ArgumentTypeError(
                     f'--input expects 1 or 2 arguments, {len(input_bag)} provided')
-            storage_options = StorageOptions()
-            storage_options.uri = input_bag[0]
+            storage_options = StorageOptions(uri=input_bag[0])
             if len(input_bag) > 1:
                 storage_options.storage_id = input_bag[1]
             input_options.append(storage_options)

diff --git a/rosbag2_py/src/rosbag2_py/_storage.cpp b/rosbag2_py/src/rosbag2_py/_storage.cpp
@@ -41,12 +41,11 @@ PYBIND11_MODULE(_storage, m) {
     &rosbag2_cpp::ConverterOptions::output_serialization_format);
 
   pybind11::class_<rosbag2_storage::StorageOptions>(m, "StorageOptions")
-  .def(pybind11::init<>())
   .def(
     pybind11::init<
       std::string, std::string, uint64_t, uint64_t, uint64_t, std::string, std::string, bool>(),
     pybind11::arg("uri"),
-    pybind11::arg("storage_id"),
+    pybind11::arg("storage_id") = "",
     pybind11::arg("max_bagfile_size") = 0,
     pybind11::arg("max_bagfile_duration") = 0,
     pybind11::arg("max_cache_size") = 0,