do not ignore return values

ros2 · Dec 12, 2018 · ebd1cc9 · ebd1cc9
1 parent a34c4d9
commit ebd1cc9
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/rosbag2_tests/test/rosbag2_tests/process_execution_helpers_unix.hpp b/rosbag2_tests/test/rosbag2_tests/process_execution_helpers_unix.hpp
@@ -31,11 +31,20 @@ using ProcessHandle = int;
 int execute_and_wait_until_completion(const std::string & command, const std::string & path)
 {
   char previous_dir[PATH_MAX];
-  getcwd(previous_dir, PATH_MAX);
+  auto ret_get_cwd = getcwd(previous_dir, PATH_MAX);
+  if (ret_get_cwd == NULL) {
+    return EXIT_FAILURE;
+  }
 
-  chdir(path.c_str());
+  auto ret_ch_dir = chdir(path.c_str());
+  if (ret_ch_dir != 0) {
+    return EXIT_FAILURE;
+  }
   auto exitcode = std::system(command.c_str());
-  chdir(previous_dir);
+  ret_ch_dir = chdir(previous_dir);
+  if (ret_ch_dir != 0) {
+    return EXIT_FAILURE;
+  }
 
   return WEXITSTATUS(exitcode);
 }