Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default metadata of compressed message #1060

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

DensoADAS
Copy link
Contributor

in case the method "compress_serialized_bag_message" does not set the meta information of the message (timestamp + topicname), the metadata is empty
to prevent this, the default values are set

…ot set it)

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
@DensoADAS DensoADAS requested a review from a team as a code owner August 5, 2022 06:10
@DensoADAS DensoADAS requested review from gbiggs and MichaelOrlov and removed request for a team August 5, 2022 06:10
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DensoADAS Thanks for your contribution.
LGTM!

@MichaelOrlov
Copy link
Contributor

Gist: https://gist.githubusercontent.com/MichaelOrlov/2468a6b75746ea21f8d5117dae86c373/raw/a10c7eecc22656cc8ca01118988377ff31bd014d/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_compression
TEST args: --packages-above rosbag2_compression
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10635

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit 6064933 into ros2:rolling Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants