Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated rosbag2_cpp/storage_options.hpp, for post-Humble releases #1064

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

emersonknapp
Copy link
Collaborator

The header was kept and marked deprecated for one release cycle, now we can delete it.

@emersonknapp emersonknapp requested a review from a team as a code owner August 11, 2022 00:23
@emersonknapp emersonknapp requested review from gbiggs and hidmic and removed request for a team August 11, 2022 00:23
…leases

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/remove-cpp-storage-options branch from b62d2f2 to 8a614a1 Compare August 11, 2022 20:53
@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/3afce477d655652fd475901116e2f184/raw/7d664cf770baf35f40a7e23084d78179e9750563/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp rosbag2_tests
TEST args: --packages-above rosbag2_cpp rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10654

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@emersonknapp emersonknapp merged commit e90d48c into rolling Aug 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/remove-cpp-storage-options branch August 19, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants