Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API samples on main branch - Rolling C++ API examples #1068

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Add API samples on main branch - Rolling C++ API examples #1068

merged 3 commits into from
Sep 30, 2022

Conversation

emersonknapp
Copy link
Collaborator

Port to latest for #869 - so that it can be kept up to date and automatically included with new Releases, rather than having to be added after the fact to distros.

@MichaelOrlov MichaelOrlov mentioned this pull request Sep 10, 2022
Closed
@emersonknapp emersonknapp marked this pull request as ready for review September 23, 2022 17:03
@emersonknapp emersonknapp requested a review from a team as a code owner September 23, 2022 17:03
@emersonknapp emersonknapp requested review from gbiggs, jhdcs and MichaelOrlov and removed request for a team September 23, 2022 17:03
@emersonknapp
Copy link
Collaborator Author

Hey @gbiggs @MichaelOrlov what do you think about this? Any concern merging it? It's mostly a direct copy but just moved directories/package names a little bit to feel closer to ros2/examples

MichaelOrlov
MichaelOrlov requested changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emersonknapp Thanks for iterating on this PR.
I would be glad to merge this PR, although I found missing create_topic and usage of the regular subscription instead of generic_subscription.

rosbag2_examples/rosbag2_examples_cpp/src/simple_bag_recorder.cpp Show resolved Hide resolved
rosbag2_examples/rosbag2_examples_cpp/src/simple_bag_recorder.cpp Show resolved Hide resolved
@emersonknapp
Copy link
Collaborator Author

Just realized this wasn't in the Action CI - so I've added that, and if it all succeeds I'll run Jenkins CI

@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/a83d5388f1b35e6e3c20302a1c9d8a58/raw/a820f6e494d6d8444ade9a1f5614ff5d86e57e38/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_examples_cpp
TEST args: --packages-above rosbag2_examples_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10916

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp
Copy link
Collaborator Author

@ros-pull-request-builder retest this please

@MichaelOrlov
Copy link
Contributor

Warning on Windows build supposed to be already fixed with #1084
@emersonknapp Do you have you branch behind fixes from #1084?

@emersonknapp
WIP grab the galactic samples
1e55748 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Rename to rosbag2_examples_cpp and update to latest Rolling usage
7951e26 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Add examples to ActionCI
64194c9 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Collaborator Author

Yeah, it was pretty far behind

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit 6a07c16 into rolling Sep 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/rolling-api-samples branch September 30, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emersonknapp @MichaelOrlov