Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sqlite3 storage implementation to rosbag2_storage_sqlite3 package #1113

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Move sqlite3 storage implementation to rosbag2_storage_sqlite3 package #1113

merged 1 commit into from
Oct 6, 2022

Conversation

emersonknapp
Copy link
Collaborator

@emersonknapp emersonknapp commented Oct 4, 2022 •
edited
Loading

Begins decoupling rosbag2 from sqlite3, which would allow a different plugin to made default easily.

@emersonknapp emersonknapp force-pushed the emersonknapp/storage-sqlite3-package branch from 30d27c7 to 4c49e61 Compare October 4, 2022 22:44
@emersonknapp emersonknapp marked this pull request as ready for review October 4, 2022 22:44
@emersonknapp emersonknapp requested a review from a team as a code owner October 4, 2022 22:44
@emersonknapp emersonknapp requested review from gbiggs and MichaelOrlov and removed request for a team October 4, 2022 22:44
MichaelOrlov
MichaelOrlov approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emersonknapp Thanks for this PR which is moving rosbag2 storage implementation for SQLite3 in separate folder and package.
I just was thinking about it and was about to add this as a topic for discussion on our Friday's WG meeting.

The implementation looks good to me!
Thanks one more time.

Approving with green CI.

@emersonknapp emersonknapp self-assigned this Oct 6, 2022
@emersonknapp
Move sqlite3 storage implementation to rosbag2_storage_sqlite3 package
c8dcd42 
Begins decoupling rosbag2 from sqlite3

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/storage-sqlite3-package branch from 4c49e61 to c8dcd42 Compare October 6, 2022 07:55
@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/6fa61d8bc2c80972208e8e1996815413/raw/0d133faf430b96f3780075fe61137717c6e3cb89/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_storage_sqlite3 rosbag2_storage_default_plugins
TEST args: --packages-above rosbag2_storage_sqlite3 rosbag2_storage_default_plugins
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10954

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit e26743e into rolling Oct 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/storage-sqlite3-package branch October 6, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees

@emersonknapp emersonknapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emersonknapp @MichaelOrlov