rosbag2_storage: expose default storage ID as method #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-rms
requested review from
emersonknapp and
hidmic
and removed request for
a team
james-rms
force-pushed
the
jrms/default-plugin-specified
branch
4 times, most recently
from
2c8186c
to
baa5abc
Compare
Signed-off-by: James Smith <james@foxglove.dev>
james-rms
force-pushed
the
jrms/default-plugin-specified
branch
from
baa5abc
to
caf2316
Compare
emersonknapp
approved these changes
Nov 2, 2022
|
Gist: https://gist.githubusercontent.com/emersonknapp/7b8356c3193a981b61899dd19caff408/raw/858120707e14f7aa488f31ee1f75ee43ddbcf19a/ros2.repos
|
|
argh, windows export rules. will try to break this into a |
Signed-off-by: James Smith <james@foxglove.dev>
james-rms
force-pushed
the
jrms/default-plugin-specified
branch
from
586447d
to
090f8af
Compare
|
Gist: https://gist.githubusercontent.com/emersonknapp/bfd2a6429c3cb7b7b16939f10c34401a/raw/858120707e14f7aa488f31ee1f75ee43ddbcf19a/ros2.repos
|
MichaelOrlov
added a commit
that referenced
this pull request
Jun 22, 2024
- Shall be applied above backport of the #1146. Due to missing `default_storage_id.hpp` Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
https://github.com/Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 22, 2024
* rosbag2_storage: expose default storage ID as method Signed-off-by: James Smith <james@foxglove.dev> (cherry picked from commit c611a80) # Conflicts: # ros2bag/ros2bag/verb/record.py # rosbag2_cpp/src/rosbag2_cpp/writer.cpp # rosbag2_py/rosbag2_py/__init__.py
MichaelOrlov
added a commit
that referenced
this pull request
Jun 22, 2024
#1146) (#1724) * rosbag2_storage: expose default storage ID as method (#1146) * rosbag2_storage: expose default storage ID as method Signed-off-by: James Smith <james@foxglove.dev> (cherry picked from commit c611a80) # Conflicts: # ros2bag/ros2bag/verb/record.py # rosbag2_cpp/src/rosbag2_cpp/writer.cpp # rosbag2_py/rosbag2_py/__init__.py * Resolve merge conflicts Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: james-rms <james@foxglove.dev> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
added a commit
that referenced
this pull request
Jun 23, 2024
- Shall be applied above backport of the #1146. Due to missing `default_storage_id.hpp` Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
added a commit
that referenced
this pull request
Jun 23, 2024
* Remove explicit sqlite3 from code (#1166) * Remove explicit sqlite3 from code Removes all code mentions of "sqlite3" from packages * rosbag2_cpp * rosbag2_performance_benchmarking * rosbag2_py * rosbag2_storage * rosbag2_transport `rosbag2_tests` and the CLI/README will be in separate PRs Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit 3300a27) # Conflicts: # rosbag2_cpp/test/rosbag2_cpp/test_info.cpp # rosbag2_cpp/test/rosbag2_cpp/test_sequential_reader.cpp # rosbag2_cpp/test/rosbag2_cpp/test_sequential_writer.cpp * Address merge conflicts - Shall be applied above backport of the #1146. Due to missing `default_storage_id.hpp` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Smith james@foxglove.dev
Fixes #1116