Make rosbag2_tests agnostic to storage implementation #1192
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/rosbag2-tests-nosql
branch
from
d147011
to
5a2ec80
Compare
emersonknapp
requested review from
hidmic and
james-rms
and removed request for
a team
There was a problem hiding this comment.
@emersonknapp Thanks for PR and cleanups for Windows specific.
I am curious if we already can include "mcap" in test parametrization for test_rosbag2_record_end_to_end?
Perhaps as follow up it would be nice to parametrize test_rosbag2_info_end_to_end and add test for checking that we can readout metadata from storage when yaml file not present.
Also the same true for the ReindexTestFixture::test_multiple_files
Will need to parametrize it and add content with multiple mcap files to the /resources/reindex_test_bags/multiple_files
|
Gist: https://gist.githubusercontent.com/emersonknapp/6d3f36d5ea849e932b244cbee4c5f6ae/raw/7f0e81b3863e85c30210e05dab7f0cbb287608b0/ros2.repos
|
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/rosbag2-tests-nosql
branch
from
82df0de
to
84e3273
Compare
|
Was missing a header for the windows build Gist: https://gist.githubusercontent.com/emersonknapp/d4893e833340f960b9dca832267c3af7/raw/7f0e81b3863e85c30210e05dab7f0cbb287608b0/ros2.repos
|
|
@ros-pull-request-builder retest this please |
* WIP removing sqlite3 specific logic from rosbag2_tests Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> * Put back the windows stuff, pull out most of the sql in record fixture Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> * WIP progress on removing all specific sqlite knowledge in rosbag2_tests Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> * Finished removing sqlite from all rosbag2_tests Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> * Parametrize record end to end test to isolate db3 to test param Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> * Diff massage Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> * Include default_storage header for windows Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> Signed-off-by: Ricardo Manríquez <ricardo.manriquez+gh@gmail.com>
Closes #1112
Remove all Sqlite3-specific logic from rosbag2_tests, including language around "database"/"db", and explicit usage of the ".db3" storage file extension.
Parameterize the recording tests so that mcap can be easily slotted in to be tested as well.