Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Humble backport]: rosbag2_storage_mcap: fix seeking behavior and iteration order #1205

Merged
merged 1 commit into from Dec 12, 2022
Merged

[Humble backport]: rosbag2_storage_mcap: fix seeking behavior and iteration order #1205

merged 1 commit into from Dec 12, 2022

Conversation

james-rms
Copy link
Contributor

Signed-off-by: James Smith james@foxglove.dev

Cherry-pick of the rosbag2_storage_mcap changes from #1196 .

@james-rms
rosbag2_storage_mcap: fix rosbag2_cpp tests
1cb039b 
Signed-off-by: James Smith <james@foxglove.dev>
@james-rms james-rms requested a review from a team as a code owner December 11, 2022 23:04
@james-rms james-rms requested review from emersonknapp and MichaelOrlov and removed request for a team December 11, 2022 23:04
emersonknapp
emersonknapp approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concern

@james-rms james-rms merged commit d65cfe3 into humble Dec 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the jrms/mcap-v0.8.0-humble branch December 12, 2022 07:18
@emersonknapp emersonknapp restored the jrms/mcap-v0.8.0-humble branch December 12, 2022 14:18
@emersonknapp
Copy link
Collaborator

Gist: https://gist.githubusercontent.com/emersonknapp/a35342db5f34c01ec8c6d7e33b787973/raw/06925314b72857e03f33ef4e8991e8d9a011dd66/ros2.repos
BUILD args: --packages-above-and-dependencies mcap_vendor rosbag2_storage_mcap
TEST args: --packages-above mcap_vendor rosbag2_storage_mcap
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11260

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov MichaelOrlov is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@james-rms @emersonknapp