-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rosbag2_cpp: test more than one storage plugin #1196
rosbag2_cpp: test more than one storage plugin #1196
Conversation
18af3f8
to
813d604
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, couple possible suggestions, lmk your thoughts on those
rosbag2_test_common/include/rosbag2_test_common/bag_filename_for_storage_id.hpp
Outdated
Show resolved
Hide resolved
rosbag2_test_common/include/rosbag2_test_common/tested_storage_ids.hpp
Outdated
Show resolved
Hide resolved
4c981f4
to
3a87fd8
Compare
3a87fd8
to
f1a44ff
Compare
Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: James Smith <james@foxglove.dev>
f1a44ff
to
412827f
Compare
Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: James Smith <james@foxglove.dev>
Gist: https://gist.githubusercontent.com/james-rms/d5d9f03159bffe918986d4b0dde89606/raw/bcc49a4ebbd695559fe6e15dca8538bb2c7aca89/ros2.repos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR parametrizes rosbag2_cpp unit tests to run using some set of "tested" storage plugins - for now this is just
sqlite3
andmcap
, but once #1160 is done I expect this would be defined as "the set of default storage plugins".It also updates
rosbag2_storage_mcap
to pass those tests. Before this PR the mcap storage plugin reader does not correctly restart iteration from after the last read message.TODO