Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print "Hidden topics are not recorded" only once. #1225

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Print "Hidden topics are not recorded" only once. #1225

merged 1 commit into from
Dec 28, 2022

Conversation

rshanor
Copy link
Contributor

@rshanor rshanor commented Dec 22, 2022 •
edited by MichaelOrlov
Loading

-Closes #1139

Signed-off-by: Rick Shanor rickshanor@gmail.com

@rshanor rshanor requested a review from a team as a code owner December 22, 2022 18:07
@rshanor rshanor requested review from MichaelOrlov and jhdcs and removed request for a team December 22, 2022 18:07
@rshanor
fix: Only print "Hidden topics are not recorded" once.
7e9e978 
Fixes ros2#1139

Signed-off-by: Rick Shanor <rickshanor@gmail.com>
@MichaelOrlov
Copy link
Contributor

Gist: https://gist.githubusercontent.com/MichaelOrlov/eb17b554d6961573f7b1a66633d06170/raw/d2223976aa02ad157706b32fb771737ac0078f79/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport
TEST args: --packages-above rosbag2_transport
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11314

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov changed the title fix: Only print "Hidden topics are not recorded" once. Print "Hidden topics are not recorded" only once. Dec 22, 2022
@rshanor
Copy link
Contributor Author

rshanor commented Dec 28, 2022

@MichaelOrlov anything else needed before merge? Thanks!

@emersonknapp emersonknapp merged commit a640ada into ros2:rolling Dec 28, 2022
tonynajjar pushed a commit to pixel-robotics/rosbag2 that referenced this pull request Mar 21, 2023
@rshanor
Print "Hidden topics are not recorded" only once. (ros2#1225)
66fbaa5 
Signed-off-by: Rick Shanor <rickshanor@gmail.com>
(cherry picked from commit a640ada)
@MichaelOrlov
Copy link
Contributor

https://github.com/Mergifyio backport humble

@mergify
Copy link

mergify bot commented May 4, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 4, 2023
@rshanor @mergify
Print "Hidden topics are not recorded" only once. (#1225)
bba6b55 
Signed-off-by: Rick Shanor <rickshanor@gmail.com>
(cherry picked from commit a640ada)
@mergify mergify bot mentioned this pull request May 4, 2023
Merged
@MichaelOrlov
Copy link
Contributor

https://github.com/Mergifyio backport iron

@mergify
Copy link

mergify bot commented May 4, 2023 •
edited
Loading

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 4, 2023
@rshanor @mergify
Print "Hidden topics are not recorded" only once. (#1225)
5e672d7 
Signed-off-by: Rick Shanor <rickshanor@gmail.com>
(cherry picked from commit a640ada)
@mergify mergify bot mentioned this pull request May 4, 2023
Closed
MichaelOrlov pushed a commit that referenced this pull request May 5, 2023
@mergify @rshanor
Print "Hidden topics are not recorded" only once. (#1225) (#1323)
c7b17af 
Signed-off-by: Rick Shanor <rickshanor@gmail.com>
(cherry picked from commit a640ada)

Co-authored-by: rshanor <rickshanor@gmail.com>
@haudren-woven haudren-woven mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Hidden topics are not recorded" Spam
3 participants
@rshanor @MichaelOrlov @emersonknapp