Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete obsolete compression_options.cpp from rosbag2_cpp (backport #1078) #1259

Merged
merged 1 commit into from Mar 11, 2023
Merged

Delete obsolete compression_options.cpp from rosbag2_cpp (backport #1078) #1259

merged 1 commit into from Mar 11, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 8, 2023

This is an automatic backport of pull request #1078 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@MichaelOrlov @mergify
Delete obsolete compression_options.cpp from rosbag2_cpp (#1078)
056a7e6 
compression_options.cpp was supposed to be moved to the
`rosbag2_compression` package in #257 but was forgotten to delete from
`rosbag2_cpp` package.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 50e28cb)
@mergify mergify bot requested a review from a team as a code owner March 8, 2023 17:08
@mergify mergify bot requested review from emersonknapp and removed request for a team March 8, 2023 17:08
@mergify mergify bot mentioned this pull request Mar 8, 2023
Merged
@mergify mergify bot requested a review from jhdcs March 8, 2023 17:08
@emersonknapp
Copy link
Collaborator

emersonknapp commented Mar 8, 2023 •
edited

Gist: https://gist.githubusercontent.com/emersonknapp/ead2b5fa23ef20c4ae77d15eda897320/raw/6ee1bd6427c9f230f9f720b4e70d5f37c34b1bee/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp
TEST args: --packages-above rosbag2_cpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11567

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit cd7b343 into humble Mar 11, 2023
13 checks passed
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-1078 branch March 11, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emersonknapp @MichaelOrlov