Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CPU affinity for producers and recorder in rosbag2_performance_benchmarking #1305

Merged
merged 1 commit into from
May 31, 2023
Merged

Set CPU affinity for producers and recorder in rosbag2_performance_benchmarking #1305

merged 1 commit into from
May 31, 2023

Conversation

MichaelOrlov
Copy link
Contributor

@MichaelOrlov MichaelOrlov force-pushed the morlov/add_cpu_usage_in_performace_benchmarking branch 2 times, most recently from 03424e6 to cd434db Compare April 24, 2023 18:45
@MichaelOrlov MichaelOrlov force-pushed the morlov/set_cpu_affinity_in_performance_bechmarking branch from 75d77f7 to f5474e0 Compare April 24, 2023 19:14
@MichaelOrlov MichaelOrlov mentioned this pull request Apr 24, 2023
Merged
@MichaelOrlov MichaelOrlov marked this pull request as ready for review April 25, 2023 22:03
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner April 25, 2023 22:03
@MichaelOrlov MichaelOrlov requested review from gbiggs, james-rms, adamdbrw and emersonknapp and removed request for a team and gbiggs April 25, 2023 22:03
@MichaelOrlov
Copy link
Contributor Author

@carlossvg Could you please review this PR?

@MichaelOrlov MichaelOrlov force-pushed the morlov/add_cpu_usage_in_performace_benchmarking branch from cd434db to 4ea295c Compare May 16, 2023 05:38
@delete-merged-branch delete-merged-branch bot deleted the branch rolling May 26, 2023 17:40
@MichaelOrlov
Set CPU affinity for producers and recorder from benchmark parameters
4f1bf1b 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov changed the base branch from morlov/add_cpu_usage_in_performace_benchmarking to rolling May 30, 2023 21:38
@MichaelOrlov
Copy link
Contributor Author

Gist: https://gist.githubusercontent.com/MichaelOrlov/e9d360d860de46f76d78390391a56cf5/raw/133a95c75a18f5fecb4f1b152890db8aa6596fb8/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_performance_benchmarking
TEST args: --packages-above rosbag2_performance_benchmarking
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12142

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@MichaelOrlov MichaelOrlov merged commit 7f0d800 into rolling May 31, 2023
14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the morlov/set_cpu_affinity_in_performance_bechmarking branch May 31, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@james-rms james-rms Awaiting requested review from james-rms james-rms is a code owner automatically assigned from ros2/tooling-reviewers

@adamdbrw adamdbrw Awaiting requested review from adamdbrw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichaelOrlov @emersonknapp