Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iron] Add config option to use storage_id parameter in benchmark_launch.py (backport #1303) #1318

Merged
merged 1 commit into from May 24, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 3, 2023

This is an automatic backport of pull request #1303 done by Mergify.

Note: Don't merge on Iron until final iron release May 23. See comment #1303 (comment) in original PR for details.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…1303)

* Add config option to use storage_id parameter in benchmark_launch.py

- Added ability to run performance benchmarking with multiple
storage plugins

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Address flake8 linter warnings

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 4b8a898)
@mergify mergify bot requested a review from a team as a code owner May 3, 2023 03:27
@mergify mergify bot requested review from MichaelOrlov and hidmic and removed request for a team May 3, 2023 03:27
@MichaelOrlov MichaelOrlov changed the title Add config option to use storage_id parameter in benchmark_launch.py (backport #1303) [iron] Add config option to use storage_id parameter in benchmark_launch.py (backport #1303) May 3, 2023
@MichaelOrlov
Copy link
Contributor

Gist: https://gist.githubusercontent.com/MichaelOrlov/6d120bdc65e3afc5d6cb697cc88c6d01/raw/f9af1f9d01aaf42f02651fd28d8c8d895610026c/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_performance_benchmarking
TEST args: --packages-above rosbag2_performance_benchmarking
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12104

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor

Linux-aarch64 CI job failed due to the lack of space on the testing machine.
re-running it one more time

  • Linux-aarch64 Build Status

@emersonknapp
Copy link
Collaborator

That's good 👍 but you can also note for the future that when the jenkins infrastructure fails like that, it automatically starts a new build for you - in this case it was https://ci.ros2.org/job/ci_linux-aarch64/13313/

@emersonknapp emersonknapp merged commit 92e8aa5 into iron May 24, 2023
14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/iron/pr-1303 branch May 24, 2023 20:21
@MichaelOrlov
Copy link
Contributor

@emersonknapp And how would I know the number of the new restarted job?
Just look around the next CI jobs which were running after the failed one?
And I don't see any mentions in the https://ci.ros2.org/job/ci_linux-aarch64/13313/ that this is a restart of the failed https://ci.ros2.org/job/ci_linux-aarch64/13312/ CI job.

@emersonknapp
Copy link
Collaborator

emersonknapp commented May 24, 2023

It's not documented at all that I know of and nothing is logged about it. Unfortunately, yes, the only way I know of to find the restarted build is by looking at the next few in the build list for one that says "Started by upstream project ci_launcher build number #" - I look for my username as the hint that it's the restarted build.

You can see in 13313 that it's started by Michael Orlov (even though you didn't start that build) - and that it's started by https://ci.ros2.org/job/ci_launcher/12104/

@MichaelOrlov
Copy link
Contributor

Thanks for the clarification.
Yeah, this is a bit cumbersome. Will need to enter in each newly started job and see if there is your name and also try to recall if it wasn't you who started this job from the launcher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants