Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iron] Workaround for flaky test_play_services running with fastrtps (backport #1556) #1562

Merged
merged 1 commit into from Feb 3, 2024
Merged

[iron] Workaround for flaky test_play_services running with fastrtps (backport #1556) #1562

merged 1 commit into from Feb 3, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 2, 2024

This is an automatic backport of pull request #1556 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@MichaelOrlov @mergify
Workaround for flaky test_play_services running with fastrtps (#1556)
0cc7bd6 
- Workaround for #1311
- Gracefully stop player in TearDown() before calling rclcpp::shutdown()
in destructor.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 54be479)
@mergify mergify bot requested a review from a team as a code owner February 2, 2024 15:28
@mergify mergify bot requested review from emersonknapp and hidmic and removed request for a team February 2, 2024 15:28
@mergify mergify bot mentioned this pull request Feb 2, 2024
Merged
@MichaelOrlov MichaelOrlov changed the title Workaround for flaky test_play_services running with fastrtps (backport #1556) [iron] Workaround for flaky test_play_services running with fastrtps (backport #1556) Feb 2, 2024
@MichaelOrlov
Copy link
Contributor

Gist: https://gist.githubusercontent.com/MichaelOrlov/27fe8af5d5692d862db8d9ef0adb14ca/raw/ae84eee468814ea143050613f5b508185691472e/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport
TEST args: --packages-above rosbag2_transport
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/13229

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit 363e4f0 into iron Feb 3, 2024
14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/iron/pr-1556 branch February 3, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros2/tooling-reviewers

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MichaelOrlov