Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ros2bag convert verb #163

Closed
oceanusxiv opened this issue Sep 22, 2019 · 1 comment · Fixed by #921
Closed

ros2bag convert verb #163

oceanusxiv opened this issue Sep 22, 2019 · 1 comment · Fixed by #921
Assignees
@Karsten1987
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@oceanusxiv
Copy link

I've recently written a small converter which just uses existing functionality of the reader and writer to convert between different serialization formats. This utility would be quite helpful for example in converting old ROS 1 bags to ROS 2 format. I was wondering if it would be a good idea to add such a convert verb as part of the ros2bag API. Let the user choose input and output storage_id and serialization_id.

If so, I can work on a small PR since I already have a PoC running.
@mabelzhang mabelzhang added the enhancement New feature or request label Sep 26, 2019
@Karsten1987
Copy link
Collaborator

Karsten1987 commented Oct 3, 2019 •
edited
Loading

Please apologize for not commenting on this earlier. I think a convert verb is very much appreciated and I am happy to review a PR on that.

@emersonknapp emersonknapp added the help wanted Extra attention is needed label Jan 29, 2020
Kettenhoax pushed a commit to Kettenhoax/rosbag2 that referenced this issue Mar 1, 2020
Add convert verb (ros2#163)
d4e13aa
@Kettenhoax Kettenhoax mentioned this issue Mar 1, 2020
Closed
Kettenhoax pushed a commit to Kettenhoax/rosbag2 that referenced this issue Mar 1, 2020
Add convert verb (ros2#163)
e7c7150 
Signed-off-by: Marcel Zeilinger <marcel.zeilinger.fl@ait.ac.at>
@emersonknapp emersonknapp mentioned this issue Dec 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karsten1987 Karsten1987

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose bag_rewrite as ros2 bag convert ros2/rosbag2
Add convert verb Kettenhoax/rosbag2
4 participants
@emersonknapp @Karsten1987 @mabelzhang @oceanusxiv